goal: Add URL to goal asset info.#4731
Merged
Merged
Conversation
Contributor
Codecov Report
@@ Coverage Diff @@
## master #4731 +/- ##
==========================================
+ Coverage 54.55% 54.57% +0.02%
==========================================
Files 414 414
Lines 53607 53608 +1
==========================================
+ Hits 29244 29256 +12
+ Misses 21935 21928 -7
+ Partials 2428 2424 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
winder
force-pushed
the
will/asset-url
branch
from
6e2fbe2 to
2f61b15
Compare
shiqizng
approved these changes
Nov 4, 2022
algochoi
approved these changes
Nov 4, 2022
Contributor
algochoi
left a comment
algochoi
left a comment
There was a problem hiding this comment.
Thanks for the changes here
This was referenced Nov 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add missing URL property, remove extra newlines
Test Plan
New e2e test.