Skip to content

Bug-Fix: Blank Import Needs Commenting for Indexer's Lint#4720

Merged
michaeldiamant merged 1 commit intomasterfrom
comment-blank-import
Nov 1, 2022
Merged

Bug-Fix: Blank Import Needs Commenting for Indexer's Lint#4720
michaeldiamant merged 1 commit intomasterfrom
comment-blank-import

Conversation

@tzaffi
Copy link
Copy Markdown
Contributor

@tzaffi tzaffi commented Nov 1, 2022

Summary

Test Plan

CI

@tzaffi tzaffi added the Bug-Fix label Nov 1, 2022
@tzaffi tzaffi changed the title Blank Import Needs Commenting for Indexer's Lint Bug-Fix: Blank Import Needs Commenting for Indexer's Lint Nov 1, 2022
@michaeldiamant
Copy link
Copy Markdown
Contributor

For ease of reference, the PR fixes the following golint error in https://app.circleci.com/pipelines/github/algorand/indexer/2728/workflows/57bf9de1-7de0-45db-b647-194456c80b35/jobs/4041?invite=true#step-113-573:

third_party/go-algorand/daemon/algod/api/swagger.go:19:8: a blank import should be only in a main or test package, or have a comment justifying it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants