AVM: fix early eval exits for Debugger#4719
Merged
Merged
Conversation
jannotti
changed the title
Codecov Report
@@ Coverage Diff @@
## master #4719 +/- ##
==========================================
- Coverage 54.37% 53.38% -1.00%
==========================================
Files 414 414
Lines 53504 53501 -3
==========================================
- Hits 29095 28559 -536
- Misses 22002 22497 +495
- Partials 2407 2445 +38
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com>
michaeldiamant
approved these changes
Nov 1, 2022
Contributor
michaeldiamant
left a comment
michaeldiamant
left a comment
There was a problem hiding this comment.
@jannotti Thanks for fixing - I confirmed TestDryrunEarlyExit fails in master as intended.
jasonpaulos
approved these changes
Nov 1, 2022
Contributor
jasonpaulos
left a comment
jasonpaulos
left a comment
There was a problem hiding this comment.
The changes make sense
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the Debugger is set, we were using a defer() to set the debugstate on every exit from eval(). Unfortunately, we exited for some conditions before the debugState was setup, so there was a nil pointer dereference while trying to communicate the error to the Debugger.
This moves those error checks down until after the debugState is setup. It also has the tiny advantage of not setting up the defer() unless it is needed (cx.Debugger is set)
(This contains some final specs changes approved by Foundation as well.)