dispenser: add input validation#4713
Merged
algojohnlee merged 1 commit intoalgorand:masterfrom Nov 1, 2022
Merged
Conversation
37b1218 to
c4eadb9
Compare
Codecov Report
@@ Coverage Diff @@
## master #4713 +/- ##
==========================================
- Coverage 54.49% 54.44% -0.06%
==========================================
Files 407 407
Lines 52425 52425
==========================================
- Hits 28569 28542 -27
- Misses 21472 21492 +20
- Partials 2384 2391 +7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
c4eadb9 to
24eb850
Compare
excalq
reviewed
Oct 31, 2022
Contributor
There was a problem hiding this comment.
excalq
previously approved these changes
Oct 31, 2022
Contributor
excalq
left a comment
There was a problem hiding this comment.
Good on you for pulling this HTML template out of the server side code.
Contributor
Author
|
@excalq I mainly did it because it didn't like embeded backticks, but it's also cleaner. |
25d3702 to
7fba75f
Compare
7fba75f to
456f0d9
Compare
onetechnical
approved these changes
Nov 1, 2022
algojack
approved these changes
Nov 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
text()instead ofhtml()References