Tests: Fix handling of empty local state in TestResourcesDataApp#4699
Merged
michaeldiamant merged 2 commits intoalgorand:masterfrom Oct 26, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4699 +/- ##
==========================================
- Coverage 54.49% 54.44% -0.06%
==========================================
Files 407 407
Lines 52389 52389
==========================================
- Hits 28548 28521 -27
- Misses 21455 21479 +24
- Partials 2386 2389 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jannotti
previously approved these changes
Oct 26, 2022
Contributor
jannotti
left a comment
There was a problem hiding this comment.
I think it's fine. it'd be slightly easier to read the diff w/o the for-loop, but I'm assuming I found the changes by looking only at the inserted if statements,
jannotti
approved these changes
Oct 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the failed
TestResourcesDataApptest run from https://app.circleci.com/pipelines/github/algorand/go-algorand/10048/workflows/dab1223e-f91d-4865-8824-ab00327a41f1/jobs/176490 by modifying the test to account for empty local state.Notes:
NumUint = 0andNumByteSlice = 0.NumUint = 0andNumByteSlice = 0,IsEmptyAppFieldsreturnstrue. I assume that's the intended behavior.appState.Schema.NumEntries() == 0.