test: metrics improvements#4639
Merged
algorandskiy merged 4 commits intoOct 26, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4639 +/- ##
==========================================
- Coverage 54.46% 54.44% -0.03%
==========================================
Files 407 407
Lines 52389 52394 +5
==========================================
- Hits 28534 28525 -9
- Misses 21467 21480 +13
- Partials 2388 2389 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
|
||
| // EnableUsageLog enables 10Hz log of CPU and RAM usage. | ||
| // Also adds 'algod_ram_usage` (number of bytes in use) to /metrics | ||
| EnableUsageLog bool `version[23]:"false"` |
Contributor
Author
There was a problem hiding this comment.
I don't think we need to for a new field not different than the Go field default.
Contributor
There was a problem hiding this comment.
okay, now we have v24. Please update version[24]:"false" and I'll merge
algorandskiy
approved these changes
Oct 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add local config
"EnableUsageLog": truewhich adds 10Hz logging of CPU and heap usage, and adds /metricsalgod_ram_usageheap bytes gauge.metrics_delta.py gains --html-summary report fragment generation.
Fixes for block history scripts to deal with some real world data.
Test Plan
This has been use in manual testing for some weeks now.