API: bump max size of teal source and dryrun#4633
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4633 +/- ##
==========================================
+ Coverage 54.32% 54.37% +0.05%
==========================================
Files 402 402
Lines 51793 51793
==========================================
+ Hits 28134 28160 +26
+ Misses 21289 21271 -18
+ Partials 2370 2362 -8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jannotti
previously approved these changes
Oct 11, 2022
Contributor
jannotti
left a comment
jannotti
left a comment
There was a problem hiding this comment.
Seems totally reasonable, and this has been requested from external contributors..
jannotti
reviewed
Oct 11, 2022
| // max compiled teal program is currently 8k | ||
| // but we allow for comments, spacing, and repeated consts | ||
| // in the source teal, allow up to 200kb | ||
| const maxTealSourceBytes = 2e5 |
Contributor
There was a problem hiding this comment.
Now that know _ is allowed in int constants in Go, I would prefer 200_000 here
barnjamin
commented
Oct 11, 2022
barnjamin
commented
Oct 11, 2022
jannotti
approved these changes
Oct 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses #4632