testing: extend transactions signature verification testing#4623
Merged
Conversation
id-ms
changed the title
id-ms
changed the title
Codecov Report
@@ Coverage Diff @@
## master #4623 +/- ##
==========================================
+ Coverage 54.27% 54.33% +0.05%
==========================================
Files 402 402
Lines 51809 51809
==========================================
+ Hits 28119 28148 +29
+ Misses 21330 21284 -46
- Partials 2360 2377 +17
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
id-ms
changed the title
algorandskiy
reviewed
Oct 3, 2022
Contributor
algorandskiy
left a comment
algorandskiy
left a comment
There was a problem hiding this comment.
Looks reasonable, but please explain the logic sig program in the last test
id-ms
force-pushed
the
sig-verification-tests
branch
from
1701a58 to
4b413c6
Compare
algonautshant
previously approved these changes
Oct 4, 2022
Contributor
algonautshant
left a comment
algonautshant
left a comment
There was a problem hiding this comment.
Look Great!
This is very nicely structured, and can easily adapted for other tests.
Just one minor comment.
algonautshant
approved these changes
Oct 4, 2022
algorandskiy
approved these changes
Oct 6, 2022
This was referenced Oct 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add several unit tests for verifying types of signatures on transactions. including: regular signature, multisignature and logicsignature
Test Plan