Skip to content

Tests: betanet-2 extended recipe#4572

Merged
onetechnical merged 7 commits intoalgorand:masterfrom
egieseke:betanet-recipe
Sep 23, 2022
Merged

Tests: betanet-2 extended recipe#4572
onetechnical merged 7 commits intoalgorand:masterfrom
egieseke:betanet-recipe

Conversation

@egieseke
Copy link
Copy Markdown
Contributor

Summary

Another Betanet recipe with participating nodes distributed to individual hosts.

Test Plan

Use algonet to deploy a network.

@egieseke egieseke self-assigned this Sep 22, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 23, 2022

Codecov Report

Merging #4572 (fe59811) into master (42b9533) will decrease coverage by 0.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4572      +/-   ##
==========================================
- Coverage   53.86%   53.63%   -0.23%     
==========================================
  Files         401      401              
  Lines       51642    51642              
==========================================
- Hits        27817    27699     -118     
- Misses      21456    21583     +127     
+ Partials     2369     2360       -9     
Impacted Files Coverage Δ
logging/cyclicWriter.go 0.00% <0.00%> (-49.47%) ⬇️
tools/network/dnssec/util.go 77.77% <0.00%> (-22.23%) ⬇️
netdeploy/remote/deployedNetwork.go 2.07% <0.00%> (-17.71%) ⬇️
agreement/demux.go 81.59% <0.00%> (-8.96%) ⬇️
crypto/merkletrie/trie.go 62.04% <0.00%> (-6.57%) ⬇️
crypto/multisig.go 40.11% <0.00%> (-5.24%) ⬇️
agreement/events.go 56.47% <0.00%> (-4.71%) ⬇️
agreement/vote.go 79.22% <0.00%> (-2.60%) ⬇️
daemon/algod/api/server/v2/test/helpers.go 71.83% <0.00%> (-2.12%) ⬇️
catchup/peerSelector.go 96.85% <0.00%> (-2.10%) ⬇️
... and 32 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Copy Markdown
Contributor

@onetechnical onetechnical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer a different name (betanet-extended? betanet-npn?) but otherwise it's fine. I think I also would have taken a look at the IP distribution, but if we are replicating the perf anomalies I'm okay with this as is.

@onetechnical onetechnical changed the title Betanet recipe Tests: betanet-2 extended recipe Sep 23, 2022
@onetechnical onetechnical merged commit 96a1e1b into algorand:master Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants