telemetry: add StartupEventDetails.Overrides

[cce]

Summary

For nodes with telemetry enabled, this adds some additional information at startup time about performance-sensitive configuration defaults that have been overridden.

Test Plan

Added unit test.

[winder]

Left some suggestions

[winder]

Consider reporting all overrides so that we don't have to keep updating this in the future (or forgetting to).

[cce]

I would prefer to keep it very limited and pre-defined to start, because there are a lot of various ways we automatically change config values at startup time, and there are also config vars that are private or not interesting/useful to know if they were changed.

[gmalouf]

Having to remember later on what we do/don't care about can brittle.

[algorandskiy]

why not adding these add annotations to the config struct, and let GetNonDefaultConfigValues process annotations and not this map stored very separately from the config?
Or at least put in into localTemplate.go with a comment explaining what is it?

[cce]

oh a struct tag would be a good idea!

[codecov]

Codecov Report

Merging #4563 (17c1525) into master (175d5aa) will decrease coverage by 0.06%.
The diff coverage is 64.28%.

@@            Coverage Diff             @@
##           master    #4563      +/-   ##
==========================================
- Coverage   54.15%   54.09%   -0.07%     
==========================================
  Files         401      401              
  Lines       51628    51642      +14     
==========================================
- Hits        27960    27936      -24     
- Misses      21319    21349      +30     
- Partials     2349     2357       +8     

Impacted Files	Coverage Δ
cmd/algod/main.go	0.00% <0.00%> (ø)
config/migrate.go	75.60% <81.81%> (+0.60%)	⬆️
ledger/voters.go	68.65% <0.00%> (-4.48%)	⬇️
util/db/dbutil.go	44.24% <0.00%> (-4.25%)	⬇️
ledger/blockqueue.go	84.48% <0.00%> (-4.03%)	⬇️
ledger/tracker.go	74.04% <0.00%> (-3.83%)	⬇️
catchup/peerSelector.go	98.95% <0.00%> (-1.05%)	⬇️
cmd/tealdbg/debugger.go	72.69% <0.00%> (-0.81%)	⬇️
ledger/acctupdates.go	69.59% <0.00%> (-0.60%)	⬇️
ledger/acctonline.go	77.60% <0.00%> (-0.53%)	⬇️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[gmalouf]

Agree with Will on future proofing overridden configs, but not enough to block moving forward.

[cce]

manual testing, after setting config to:

{
    "Version": 16,
    "CatchupBlockValidateMode": 3,
    "LogArchiveName": "node.log.{{.Year}}{{.Month}}{{.Day}}_{{.Hour}}{{.Minute}}{{.Second}}-{{.EndYear}}{{.EndMonth}}{{.EndDay}}_{{.EndHour}}{{.EndMinute}}{{.EndSecond}}.gz",
    "TxPoolSize": 25000,
    "AgreementIncomingProposalsQueueLength": 50,
    "MaxAPIResourcesPerAccount": 50000,
    "ProposalAssemblyTime": 350000000,
    "EndpointAddress": "0.0.0.0:8081"
}

node.log contains:

{"details":{"Version":"3.10.157914","CommitHash":"17c15254","Branch":"report-nondefault-config","Channel":"dev","InstanceHash":"X","Overrides":[{"Name":"ProposalAssemblyTime","Value":350000000},{"Name":"TxPoolSize","Value":25000},{"Name":"AgreementIncomingProposalsQueueLength","Value":50},{"Name":"CatchupBlockValidateMode","Value":3}]},"file":"telemetry.go","function":"github.com/algorand/go-algorand/logging.(*telemetryState).logTelemetry","instanceName":"X","level":"info","line":261,"msg":"/ApplicationState/Startup","session":"X","time":"2022-09-20T10:16:24.337395-04:00","v":"3.10.157914"}