Skip to content

Testing: fix TestAttestorsChange#4510

Merged
algorandskiy merged 2 commits intoalgorand:masterfrom
id-ms:fix-attestors-change-test
Sep 6, 2022
Merged

Testing: fix TestAttestorsChange#4510
algorandskiy merged 2 commits intoalgorand:masterfrom
id-ms:fix-attestors-change-test

Conversation

@id-ms
Copy link
Copy Markdown
Contributor

@id-ms id-ms commented Sep 5, 2022

Summary

TestAttestorsChange tries to compare account's balance with the state proof's total online stake.
The test sample the balance on a stateproof round (where the onlineStake field appears), However the balances should be sampled StateProofVotersLookback rounds before.

Test Plan

@id-ms id-ms added test Improves testing of existing code Team Sphinx labels Sep 5, 2022
@id-ms id-ms self-assigned this Sep 5, 2022
@id-ms id-ms added Enhancement and removed test Improves testing of existing code labels Sep 5, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 5, 2022

Codecov Report

Merging #4510 (8258d11) into master (eeeb7c3) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4510      +/-   ##
==========================================
- Coverage   55.30%   55.29%   -0.01%     
==========================================
  Files         398      398              
  Lines       50336    50336              
==========================================
- Hits        27840    27835       -5     
- Misses      20173    20174       +1     
- Partials     2323     2327       +4     
Impacted Files Coverage Δ
agreement/cryptoVerifier.go 67.60% <0.00%> (-2.12%) ⬇️
agreement/proposalManager.go 96.07% <0.00%> (-1.97%) ⬇️
data/transactions/verify/txn.go 43.75% <0.00%> (-0.90%) ⬇️
ledger/acctupdates.go 69.59% <0.00%> (-0.60%) ⬇️
ledger/acctonline.go 78.12% <0.00%> (-0.53%) ⬇️
ledger/accountdb.go 72.87% <0.00%> (-0.16%) ⬇️
network/wsNetwork.go 65.10% <0.00%> (+0.28%) ⬆️
cmd/tealdbg/debugger.go 73.49% <0.00%> (+0.80%) ⬆️
ledger/tracker.go 77.87% <0.00%> (+2.97%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@id-ms id-ms requested a review from algorandskiy September 6, 2022 10:50
@algorandskiy algorandskiy merged commit 00b37f2 into algorand:master Sep 6, 2022
@id-ms id-ms deleted the fix-attestors-change-test branch September 7, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants