metrics: TagCounter gains a tag set to filter on#4503
Merged
Conversation
unknown tags can be counted under one substitute tag e.g. "UNK" limit protocol counters to known protocol tags
Codecov Report
@@ Coverage Diff @@
## master #4503 +/- ##
==========================================
- Coverage 55.25% 55.22% -0.04%
==========================================
Files 398 398
Lines 50297 50310 +13
==========================================
- Hits 27793 27784 -9
- Misses 20171 20192 +21
- Partials 2333 2334 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
onetechnical
pushed a commit
to onetechnical/go-algorand
that referenced
this pull request
Sep 8, 2022
unknown tags can be counted under one substitute tag e.g. "UNK" limit protocol counters to known protocol tags
This was referenced Sep 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unknown tags can be counted under one substitute tag e.g. "UNK"
limit protocol counters to known protocol tags
Test Plan
Added unit test.