CICD: Fixing golangci-lint and github action#4483
Merged
algojohnlee merged 14 commits intoalgorand:masterfrom Aug 30, 2022
Merged
CICD: Fixing golangci-lint and github action#4483algojohnlee merged 14 commits intoalgorand:masterfrom
algojohnlee merged 14 commits intoalgorand:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4483 +/- ##
==========================================
+ Coverage 55.21% 55.26% +0.04%
==========================================
Files 398 398
Lines 50297 50297
==========================================
+ Hits 27772 27797 +25
+ Misses 20191 20169 -22
+ Partials 2334 2331 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cce
reviewed
Aug 29, 2022
cce
reviewed
Aug 29, 2022
algojack
changed the title
egieseke
approved these changes
Aug 30, 2022
| txn(t, l, eval, &inner) | ||
| vb := endBlock(t, l, eval) | ||
| innerId := vb.Block().Payset[0].ApplicationID | ||
| innerID := vb.Block().Payset[0].ApplicationID |
Contributor
There was a problem hiding this comment.
Did the linter catch this?
Contributor
Author
There was a problem hiding this comment.
yes, it caught it, and cce fixed it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.