e2e tests: tag e2e test data with commit hash #4481
Merged
algorandskiy merged 2 commits intoalgorand:masterfrom Aug 29, 2022
Merged
e2e tests: tag e2e test data with commit hash #4481algorandskiy merged 2 commits intoalgorand:masterfrom
algorandskiy merged 2 commits intoalgorand:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4481 +/- ##
==========================================
- Coverage 55.19% 55.17% -0.02%
==========================================
Files 398 398
Lines 50165 50165
==========================================
- Hits 27689 27680 -9
- Misses 20159 20169 +10
+ Partials 2317 2316 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Eric-Warehime
approved these changes
Aug 26, 2022
algorandskiy
requested changes
Aug 29, 2022
Contributor
algorandskiy
left a comment
algorandskiy
left a comment
There was a problem hiding this comment.
PR/commit headline: enhancement: -> component name. In this case tests: or e2e tests:, or something else
shiqizng
changed the title
algorandskiy
approved these changes
Aug 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is for resolving #1174. Another copy of rel/nightly e2e artifact is uploaded to file path algorand-testdata/indexer/e2e4/<commit_hash>/. This way, indexer's e2e test can use data generated from a specific version of go-algorand.
Test Plan
check that data is created in s3 with correct file path.