Skip to content

stateproof: always set StateProofNextRound in metric#4475

Merged
algorandskiy merged 2 commits into
algorand:masterfrom
algonautshant:shant/next_sp_round_fix
Aug 29, 2022
Merged

stateproof: always set StateProofNextRound in metric#4475
algorandskiy merged 2 commits into
algorand:masterfrom
algonautshant:shant/next_sp_round_fix

Conversation

@algonautshant
Copy link
Copy Markdown
Contributor

Set the StateProofNextRound to metric stats when the block payset is empty.

Added a check for this in the logging test.

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 26, 2022

Codecov Report

Merging #4475 (625eae8) into master (0c09407) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4475      +/-   ##
==========================================
- Coverage   55.25%   55.24%   -0.01%     
==========================================
  Files         398      398              
  Lines       50265    50265              
==========================================
- Hits        27772    27768       -4     
- Misses      20176    20179       +3     
- Partials     2317     2318       +1     
Impacted Files Coverage Δ
data/pools/transactionPool.go 50.69% <100.00%> (ø)
ledger/tracker.go 74.89% <0.00%> (-2.98%) ⬇️
network/wsPeer.go 65.47% <0.00%> (-2.74%) ⬇️
network/wsNetwork.go 64.91% <0.00%> (+0.28%) ⬆️
catchup/service.go 69.38% <0.00%> (+0.49%) ⬆️
ledger/acctupdates.go 69.89% <0.00%> (+0.59%) ⬆️
cmd/tealdbg/debugger.go 73.49% <0.00%> (+0.80%) ⬆️
data/transactions/verify/txn.go 44.64% <0.00%> (+0.89%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@algonautshant algonautshant requested a review from Aharonee August 26, 2022 16:00
Copy link
Copy Markdown
Contributor

@id-ms id-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants