Skip to content

tests: fix top online warning in TestAcctUpdatesCachesInitialization#4451

Merged
algorandskiy merged 1 commit into
algorand:masterfrom
algorandskiy:pavel/test-ledger-cache-init
Aug 23, 2022
Merged

tests: fix top online warning in TestAcctUpdatesCachesInitialization#4451
algorandskiy merged 1 commit into
algorand:masterfrom
algorandskiy:pavel/test-ledger-cache-init

Conversation

@algorandskiy
Copy link
Copy Markdown
Contributor

Summary

TestAcctUpdatesCachesInitialization generates online/offline deltas and sets VoteLastValid=1000.
Since the tests goes beyond 1000 rounds, most of the accounts became expired for stateproof and TopOnlineAccounts renders a warning.

Test Plan

This is a test

Copy link
Copy Markdown
Contributor

@id-ms id-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 23, 2022

Codecov Report

Merging #4451 (4853866) into master (924d2fb) will increase coverage by 3.72%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4451      +/-   ##
==========================================
+ Coverage   51.51%   55.23%   +3.72%     
==========================================
  Files         398      398              
  Lines       50165    50165              
==========================================
+ Hits        25841    27710    +1869     
+ Misses      21934    20144    -1790     
+ Partials     2390     2311      -79     
Impacted Files Coverage Δ
cmd/algoh/blockWatcher.go 77.77% <0.00%> (-3.18%) ⬇️
network/wsNetwork.go 64.82% <0.00%> (+0.28%) ⬆️
network/requestTracker.go 71.12% <0.00%> (+0.43%) ⬆️
ledger/internal/prefetcher/prefetcher.go 68.18% <0.00%> (+0.45%) ⬆️
node/node.go 4.43% <0.00%> (+0.47%) ⬆️
daemon/algod/api/server/v2/dryrun.go 70.82% <0.00%> (+0.60%) ⬆️
agreement/pseudonode.go 70.07% <0.00%> (+0.72%) ⬆️
ledger/catchpointwriter.go 57.65% <0.00%> (+0.90%) ⬆️
ledger/acctonline.go 78.36% <0.00%> (+1.05%) ⬆️
crypto/merkletrie/cache.go 89.02% <0.00%> (+1.18%) ⬆️
... and 111 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@algorandskiy algorandskiy merged commit b38f054 into algorand:master Aug 23, 2022
@algorandskiy algorandskiy deleted the pavel/test-ledger-cache-init branch March 16, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants