state proofs: update state proof totals calculation#4445
Merged
algorandskiy merged 11 commits intomasterfrom Aug 24, 2022
Merged
state proofs: update state proof totals calculation#4445algorandskiy merged 11 commits intomasterfrom
algorandskiy merged 11 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4445 +/- ##
==========================================
+ Coverage 55.19% 55.21% +0.02%
==========================================
Files 398 398
Lines 50165 50175 +10
==========================================
+ Hits 27689 27705 +16
+ Misses 20159 20155 -4
+ Partials 2317 2315 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jannotti
reviewed
Aug 24, 2022
jannotti
approved these changes
Aug 24, 2022
Contributor
jannotti
left a comment
jannotti
left a comment
There was a problem hiding this comment.
Looks right to me. Though it seems barely worth it, given the small amounts of rewards that are paid these days, and that all participants have necessarily received rewards fairly recently, when they last keyreg'd.
| // 10046 = (12 * 60 * 60 / 4.3) | ||
| // for the sake of future manual calculations, we'll round that down a bit : | ||
| v33.ApprovedUpgrades[protocol.ConsensusV34] = 10000 | ||
| v33.ApprovedUpgrades[protocol.ConsensusV35] = 10000 |
Contributor
There was a problem hiding this comment.
shouldn't we have v33 upgradeable to v34?
Contributor
Author
There was a problem hiding this comment.
we were going to skip v34 (what is currently on betanet) and let mainnet go from v32 to v33 to v35
algorandskiy
approved these changes
Aug 24, 2022
onetechnical
pushed a commit
to onetechnical/go-algorand
that referenced
this pull request
Aug 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the total weight to subtract rewards from accounts who have expired or have keys that do not match the weight commitment round.
Test Plan
New tests needed