Test: Get rid of references and uses of go lint and go vet#4444
Merged
cce merged 1 commit intoalgorand:masterfrom Aug 23, 2022
Merged
Test: Get rid of references and uses of go lint and go vet#4444cce merged 1 commit intoalgorand:masterfrom
go lint and go vet#4444cce merged 1 commit intoalgorand:masterfrom
Conversation
jannotti
force-pushed
the
exterminate-lint
branch
from
ba64b7d to
80246b7
Compare
Codecov Report
@@ Coverage Diff @@
## master #4444 +/- ##
==========================================
+ Coverage 55.19% 55.21% +0.02%
==========================================
Files 398 398
Lines 50165 50165
==========================================
+ Hits 27689 27700 +11
+ Misses 20159 20150 -9
+ Partials 2317 2315 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algorandskiy
approved these changes
Aug 23, 2022
cce
reviewed
Aug 23, 2022
| # Work our way back over time to be clean against all these | ||
| # checkers. If you'd like to contribute, raise the number after ~, | ||
| # run the linter and dig in. | ||
| new-from-rev: eb019291beed556ec6ac1ceb4a15114ce4df0c57~25 |
cce
approved these changes
Aug 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
golangci-lint subsumes both of these tools