Skip to content

Testing: Fix voterTracker tests#4441

Merged
algorandskiy merged 1 commit intoalgorand:masterfrom
id-ms:fix-voterTrackerTests
Aug 22, 2022
Merged

Testing: Fix voterTracker tests#4441
algorandskiy merged 1 commit intoalgorand:masterfrom
id-ms:fix-voterTrackerTests

Conversation

@id-ms
Copy link
Copy Markdown
Contributor

@id-ms id-ms commented Aug 21, 2022

Summary

The unit tests for the voterTracker didn't correctly calculate the account's total stake. This lead to an error message on logs.

Test Plan

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 21, 2022

Codecov Report

Merging #4441 (a821498) into master (7932403) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4441      +/-   ##
==========================================
+ Coverage   55.21%   55.23%   +0.01%     
==========================================
  Files         398      398              
  Lines       50165    50165              
==========================================
+ Hits        27701    27709       +8     
+ Misses      20153    20147       -6     
+ Partials     2311     2309       -2     
Impacted Files Coverage Δ
ledger/blockqueue.go 85.63% <0.00%> (-2.88%) ⬇️
catchup/peerSelector.go 98.95% <0.00%> (-1.05%) ⬇️
ledger/acctonline.go 78.89% <0.00%> (-0.53%) ⬇️
catchup/service.go 68.88% <0.00%> (-0.50%) ⬇️
network/wsNetwork.go 64.63% <0.00%> (-0.29%) ⬇️
ledger/accountdb.go 72.74% <0.00%> (+0.07%) ⬆️
ledger/tracker.go 75.64% <0.00%> (+0.85%) ⬆️
network/wsPeer.go 67.67% <0.00%> (+2.19%) ⬆️
util/db/dbutil.go 48.48% <0.00%> (+4.24%) ⬆️
ledger/roundlru.go 96.22% <0.00%> (+5.66%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@id-ms id-ms requested a review from algorandskiy August 21, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants