lint: Update linter version#4434
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4434 +/- ##
==========================================
- Coverage 55.23% 55.20% -0.04%
==========================================
Files 398 398
Lines 50148 50148
==========================================
- Hits 27700 27682 -18
- Misses 20136 20150 +14
- Partials 2312 2316 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
winder
approved these changes
Aug 19, 2022
jannotti
reviewed
Aug 20, 2022
Comment on lines
+65
to
+66
| # staticcheck: we'll keep using ioutil for now | ||
| - 'SA1019: "io/ioutil" has been deprecated since Go 1.16' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Following on #4418 and #4241 this upgrades the version of golangci-lint to match the lint-cleanliness achieved in #4241. (Older versions of golangci-lint were producing false positives)
Test Plan
All tests should pass.