ledger: do not shadow db error in account lookup#4425
Merged
algorandskiy merged 2 commits intoAug 19, 2022
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4425 +/- ##
==========================================
+ Coverage 55.13% 55.16% +0.03%
==========================================
Files 397 397
Lines 50073 50079 +6
==========================================
+ Hits 27607 27627 +20
+ Misses 20170 20156 -14
Partials 2296 2296
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jannotti
previously approved these changes
Aug 17, 2022
Contributor
jannotti
left a comment
jannotti
left a comment
There was a problem hiding this comment.
Looks good - should give us the more important error detail.
algorandskiy
commented
Aug 18, 2022
Contributor
Author
algorandskiy
left a comment
algorandskiy
left a comment
There was a problem hiding this comment.
Fixed CR feedback
jannotti
reviewed
Aug 18, 2022
algorandskiy
force-pushed
the
pavel/ledger-lookup-error
branch
from
f840fb3 to
996ffbf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DB lookup might fail and acctupdates' lookup method return not original error but overwritten by another one.
This makes debugging a bit harder.
Test Plan
Existing tests