CI: Expose configuration to ignore parent E2E expect test runner invocations#4422
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4422 +/- ##
==========================================
- Coverage 55.18% 55.13% -0.06%
==========================================
Files 397 397
Lines 50073 50073
==========================================
- Hits 27634 27606 -28
- Misses 20150 20170 +20
- Partials 2289 2297 +8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends
scripts/buildtools/check_tests.pyto customize tests to ignore via--ignored-tests. The motivation is to acquiescecheck_tests.pywarnings about E2E expect tests run multiple times.In another branch, I saw warnings in https://app.circleci.com/pipelines/github/algorand/go-algorand/8787/workflows/a566ab26-42ad-48de-940d-08d504ce1c15/jobs/158801?invite=true#step-103-7. Reproduced below for convenience:
Upon inspection, I realized these tests are parent E2E test runners for expect tests. They're invoked multiple times by-design and the advice to add partitioning does not apply.
As a band aid, the PR exposes a way to ignore these tests. See the PR's builds for proof that the warnings disappear.
go testflags. I can envision managing the ignore list as worse than the status quo.Test Plan
Run CI.