Skip to content

CI: Ensure algod_expect_test.go tests run by avoiding double partitioning#4421

Merged
cce merged 2 commits into
masterfrom
fix_partitioning
Aug 17, 2022
Merged

CI: Ensure algod_expect_test.go tests run by avoiding double partitioning#4421
cce merged 2 commits into
masterfrom
fix_partitioning

Conversation

@michaeldiamant
Copy link
Copy Markdown
Contributor

Summary

The PR fixes a partitioning configuration error in test/e2e-go/cli/algod/expect/algod_expect_test.go. The parent test runner should not partition itself because its subtests perform partitioning.

============= UNINTENTIONALLY SKIPPED ============
1 tests were skipped unintentionally
github.com/algorand/go-algorand/test/e2e-go/cli/algod/expect TestAlgodWithExpect/algodTelemetryLocationTest.exp -- skipped unintentionally. (due to partitiontest.PartitionTest() being called twice?)
1 tests were skipped unintentionally.
==================================================

Test Plan

Run CI.

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 17, 2022

Codecov Report

Merging #4421 (4bea609) into master (f156f69) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4421      +/-   ##
==========================================
- Coverage   55.18%   55.14%   -0.05%     
==========================================
  Files         397      397              
  Lines       50073    50073              
==========================================
- Hits        27634    27612      -22     
- Misses      20150    20166      +16     
- Partials     2289     2295       +6     
Impacted Files Coverage Δ
ledger/roundlru.go 90.56% <0.00%> (-5.67%) ⬇️
ledger/blockqueue.go 85.63% <0.00%> (-2.88%) ⬇️
crypto/merkletrie/trie.go 66.42% <0.00%> (-2.19%) ⬇️
crypto/merkletrie/node.go 91.62% <0.00%> (-1.87%) ⬇️
catchup/service.go 68.64% <0.00%> (-0.75%) ⬇️
ledger/acctupdates.go 69.92% <0.00%> (-0.61%) ⬇️
network/wsPeer.go 67.67% <0.00%> (-0.55%) ⬇️
network/wsNetwork.go 64.89% <0.00%> (+0.19%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@michaeldiamant michaeldiamant changed the title Ensure algod_expect_test.go tests run by avoiding double partitioning CI: Ensure algod_expect_test.go tests run by avoiding double partitioning Aug 17, 2022
Comment thread test/e2e-go/cli/algod/expect/algod_expect_test.go Outdated
jannotti
jannotti previously approved these changes Aug 17, 2022
Co-authored-by: John Jannotti <jannotti@gmail.com>
@cce
Copy link
Copy Markdown
Contributor

cce commented Aug 17, 2022

LGTM — another way to mark this would be

//nolint:partitiontest // Causes double partition, so commented out on purpose

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants