CI: Ensure algod_expect_test.go tests run by avoiding double partitioning#4421
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4421 +/- ##
==========================================
- Coverage 55.18% 55.14% -0.05%
==========================================
Files 397 397
Lines 50073 50073
==========================================
- Hits 27634 27612 -22
- Misses 20150 20166 +16
- Partials 2289 2295 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jannotti
reviewed
Aug 17, 2022
jannotti
previously approved these changes
Aug 17, 2022
Co-authored-by: John Jannotti <jannotti@gmail.com>
jannotti
approved these changes
Aug 17, 2022
Contributor
|
LGTM — another way to mark this would be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The PR fixes a partitioning configuration error in
test/e2e-go/cli/algod/expect/algod_expect_test.go. The parent test runner should not partition itself because its subtests perform partitioning.Test Plan
Run CI.