Skip to content

Quality: Switch from golint to golangci-lint. #4418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
winder merged 4 commits into from
Aug 19, 2022
Merged

Quality: Switch from golint to golangci-lint. #4418

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ccac7a5
Switch from golint to golangci-lint.
winder Aug 16, 2022
f559580
Revert new-from-rev change.
winder Aug 19, 2022
aaced58
Merge remote-tracking branch 'upstream/master' into will/golangci-lint
winder Aug 19, 2022
f40ca28
Update .golangci.yml
winder Aug 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ linters:
enable:
- errcheck
- gofmt
- revive
Comment thread
winder marked this conversation as resolved.
Outdated
- gosimple
- govet
- ineffassign
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ fix: build
$(GOPATH1)/bin/algofix */

lint: deps
$(GOPATH1)/bin/golint ./...
$(GOPATH1)/bin/golangci-lint run -c .golangci.yml

vet:
go vet ./...
Expand Down
1 change: 1 addition & 0 deletions scripts/buildtools/install_buildtools.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,3 +93,4 @@ install_go_module github.com/go-swagger/go-swagger github.com/go-swagger/go-swag
install_go_module github.com/algorand/msgp
install_go_module gotest.tools/gotestsum
install_go_module github.com/algorand/oapi-codegen github.com/algorand/oapi-codegen/cmd/oapi-codegen
install_go_module github.com/golangci/golangci-lint/cmd/golangci-lint
Comment thread
algojack marked this conversation as resolved.
1 change: 1 addition & 0 deletions scripts/buildtools/versions
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@ github.com/algorand/msgp v1.1.52
github.com/algorand/oapi-codegen v1.3.7
github.com/go-swagger/go-swagger v0.25.0
gotest.tools/gotestsum v1.6.4
github.com/golangci/golangci-lint/cmd/golangci-lint v1.41.1
Comment thread
cce marked this conversation as resolved.
1 change: 1 addition & 0 deletions scripts/check_deps.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ GO_DEPS=(
"$GO_BIN/golint"
"$GO_BIN/stringer"
"$GO_BIN/msgp"
"$GO_BIN/golangci-lint"
)

check_deps() {
Expand Down