stateproofs: Make SP e2e tests easier for arm.#4402
Merged
algorandskiy merged 1 commit intoAug 12, 2022
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4402 +/- ##
==========================================
+ Coverage 55.56% 55.58% +0.01%
==========================================
Files 400 400
Lines 50797 50797
==========================================
+ Hits 28226 28235 +9
+ Misses 20169 20166 -3
+ Partials 2402 2396 -6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algorandskiy
approved these changes
Aug 12, 2022
| partitiontest.PartitionTest(t) | ||
| defer fixtures.ShutdownSynchronizedTest(t) | ||
|
|
||
| if runtime.GOARCH == "arm" || runtime.GOARCH == "arm64" { |
Contributor
There was a problem hiding this comment.
I suggest to retain it for arm64
onetechnical
pushed a commit
to onetechnical/go-algorand
that referenced
this pull request
Aug 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rarely, SP e2e tests may fail on ARM. This is because the tests spins around 7 nodes, which may overwhelm the ARM.
Making some of the tests run on smaller network, others not run on ARM.