Merged
Conversation
Karmastic
reviewed
Jun 18, 2019
| gzip "${STATUSFILE}.asc" | ||
| aws s3 cp --quiet "${STATUSFILE}.asc.gz" "s3://algorand-devops-misc/buildlog/${RSTAMP}/${STATUSFILE}.asc.gz" | ||
| if [ ! -z "${S3_PREFIX_BUILDLOG}" ]; then | ||
| aws s3 cp --quiet "${STATUSFILE}.asc.gz" "${S3_PREFIX_BUILDLOG}/${RSTAMP}/${STATUSFILE}.asc.gz" |
Contributor
There was a problem hiding this comment.
any reason this is silent but buildlog copy below (in build_release_local.sh) is not?
Contributor
Author
There was a problem hiding this comment.
this script is expected to run as a script and be recorded to a log file. aws s3 cp without --quiet prints out status a couple times a second and floods that log file. build_release_local.sh is at this time really more of a copy&paste source of things to do to run the build that get run in the build engineer's terminal.
Karmastic
approved these changes
Jun 18, 2019
Contributor
Karmastic
left a comment
Karmastic
left a comment
There was a problem hiding this comment.
One question but not a blocker.
winder
reviewed
Jun 18, 2019
|
|
||
| # For now, we only deploy packages with telemetry (so we can transition smoothly). | ||
| # Copy xxx_channel_yyy -> xxx_channel-telem_yyy | ||
| if [[ ("${var}" = "") && (! -z ${TRANSITION_TELEMETRY_BUILDS}) ]]; then |
Contributor
There was a problem hiding this comment.
Have we transitioned? Can we remove this flag entirely?
algobolson
added a commit
that referenced
this pull request
Jun 18, 2019
* stop making copies to obsolete -telem package names * only upload when s3 destination vars are set fixes to deb relases
Contributor
|
Yes we have transitioned several builds ago. Anyone still on an old build
should reinstall or just specify -c stable
…On Tue, Jun 18, 2019 at 08:29 Will Winder ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In scripts/build_packages.sh
<#44 (comment)>:
> @@ -131,13 +131,5 @@ for var in "${VARIATION_ARRAY[@]}"; do
cp -p *.deb ${PKG_ROOT}/${GATE_PREFIX}algorand_${CHANNEL}_${PKG_NAME}_${FULLVERSION}.deb
popd
fi
-
- # For now, we only deploy packages with telemetry (so we can transition smoothly).
- # Copy xxx_channel_yyy -> xxx_channel-telem_yyy
- if [[ ("${var}" = "") && (! -z ${TRANSITION_TELEMETRY_BUILDS}) ]]; then
Have we transitioned? Can we remove this flag entirely?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#44?email_source=notifications&email_token=AGB6D53UYVU3CIR2MUDE6F3P3DIKZA5CNFSM4HY2KYW2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB33OJ2A#pullrequestreview-251061480>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGB6D54GEMRW4VJM5GVSGWDP3DIKZANCNFSM4HY2KYWQ>
.
|
pzbitskiy
pushed a commit
to pzbitskiy/go-algorand
that referenced
this pull request
Apr 22, 2020
Debugger CLI and fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.