Skip to content

Build: Remove mac_amd64 from our default triggered builds.#4397

Merged
gmalouf merged 2 commits intomasterfrom
disable-mac-builds-on-pr
Aug 11, 2022
Merged

Build: Remove mac_amd64 from our default triggered builds.#4397
gmalouf merged 2 commits intomasterfrom
disable-mac-builds-on-pr

Conversation

@gmalouf
Copy link
Copy Markdown
Contributor

@gmalouf gmalouf commented Aug 11, 2022

Summary

Disabling Mac builds from our default triggered runs on Circle.

Test Plan

Run build from within the PR - Circle should respect its config file on this branch.

@gmalouf gmalouf changed the title Remove mac_amd64 from our default triggered builds. Build: Remove mac_amd64 from our default triggered builds. Aug 11, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 11, 2022

Codecov Report

Merging #4397 (adb6ad8) into master (e3ffb42) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4397      +/-   ##
==========================================
- Coverage   55.59%   55.56%   -0.03%     
==========================================
  Files         403      400       -3     
  Lines       50806    50786      -20     
==========================================
- Hits        28246    28221      -25     
+ Misses      20166    20165       -1     
- Partials     2394     2400       +6     
Impacted Files Coverage Δ
ledger/tracker.go 73.93% <0.00%> (-6.42%) ⬇️
ledger/roundlru.go 90.56% <0.00%> (-5.67%) ⬇️
ledger/blockqueue.go 85.63% <0.00%> (-2.88%) ⬇️
crypto/merkletrie/trie.go 66.42% <0.00%> (-2.19%) ⬇️
crypto/merkletrie/node.go 91.62% <0.00%> (-1.87%) ⬇️
data/transactions/verify/txn.go 43.85% <0.00%> (-0.88%) ⬇️
util/db/dbutil.go 48.48% <0.00%> (-0.61%) ⬇️
util/sleep.go
util/db/fullfsync_darwin.go
libgoal/lockedFileUnix.go
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gmalouf gmalouf merged commit 16e4165 into master Aug 11, 2022
Copy link
Copy Markdown
Contributor

@algobarb algobarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants