CI: Four missing partiontest calls. And minor doc update.#4394
Merged
algorandskiy merged 1 commit intoalgorand:masterfrom Aug 11, 2022
Merged
CI: Four missing partiontest calls. And minor doc update.#4394algorandskiy merged 1 commit intoalgorand:masterfrom
algorandskiy merged 1 commit intoalgorand:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4394 +/- ##
==========================================
- Coverage 55.63% 55.57% -0.06%
==========================================
Files 403 403
Lines 50805 50805
==========================================
- Hits 28263 28235 -28
- Misses 20148 20170 +22
- Partials 2394 2400 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algorandskiy
approved these changes
Aug 11, 2022
jasonpaulos
approved these changes
Aug 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were missing some partitiontest calls. I don't know why the checking didn't fail. It DID see the problem

It seems to me that a) The linter was supposed to complain. and b) the test checker should have failed.