tests: fix TestBasicCatchpointCatchup#4390
Merged
algorandskiy merged 3 commits intoAug 11, 2022
Merged
Conversation
* After the protocol upgrade nodes required to have MaxTxnLife + DeeperBlockHeaderHistory blocks that violated the test's expectations. * Fixed a rare case when a block exists in a local ledger but peer's stat is still updated even if no communications were made.
Codecov Report
@@ Coverage Diff @@
## master #4390 +/- ##
==========================================
- Coverage 55.63% 55.62% -0.01%
==========================================
Files 403 403
Lines 50805 50806 +1
==========================================
- Hits 28263 28261 -2
- Misses 20148 20154 +6
+ Partials 2394 2391 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algonautshant
approved these changes
Aug 11, 2022
Contributor
algonautshant
left a comment
algonautshant
left a comment
There was a problem hiding this comment.
Looks great!
Minor comment.
algorandskiy
force-pushed
the
pavel/catchpoint-catchup-test-fix
branch
from
c4dacb8 to
8f59016
Compare
algonautshant
approved these changes
Aug 11, 2022
michaeldiamant
approved these changes
Aug 11, 2022
Contributor
michaeldiamant
left a comment
michaeldiamant
left a comment
There was a problem hiding this comment.
@algorandskiy Thanks for your continued efforts to reduce flaky tests!
My approval is limited to test/e2e-go/features/catchup/catchpointCatchup_test.go and supporting test changes.
I'm not familiar enough with psp changes in catchup/catchpointService.go to feel comfortable approving it. I trust your judgment to solicit additional reviews as you feel necessary.
onetechnical
pushed a commit
to onetechnical/go-algorand
that referenced
this pull request
Aug 15, 2022
* After the protocol upgrade nodes required to have MaxTxnLife + DeeperBlockHeaderHistory blocks that violated the test's expectations. * Fixed a rare case when a block exists in a local ledger but peer's stat is still updated even if no communications were made.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
blocks that violated the test's expectations.
even if no communications were made.
Tests
Run the test multiple times