test: wait until new block is committed to BlockQueue#4381
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4381 +/- ##
=======================================
Coverage 55.60% 55.61%
=======================================
Files 403 403
Lines 50801 50801
=======================================
+ Hits 28248 28251 +3
+ Misses 20159 20157 -2
+ Partials 2394 2393 -1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
jannotti
reviewed
Aug 9, 2022
michaeldiamant
approved these changes
Aug 10, 2022
Contributor
michaeldiamant
left a comment
There was a problem hiding this comment.
@ahangsu Thanks for the effort here - Hopefully, we've addressed a source of flakyness.
Additionally, I performed a cursory call hierarchy inspection for AddValidatedBlock. I found no production code paths liable for the same class of data race.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
By #4349, we noticed a datarace in
testMaxInnerTxnSingleAppCall. This PR waits the ledger to commit every new blocks inblockQueueto be committed in functionendBlock.