Tests: Remove unused newAcctUpdates parameter: dbPathPrefix#4353
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4353 +/- ##
==========================================
+ Coverage 55.23% 55.26% +0.02%
==========================================
Files 395 395
Lines 50352 50352
==========================================
+ Hits 27811 27826 +15
+ Misses 20149 20133 -16
- Partials 2392 2393 +1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
algorandskiy
approved these changes
Aug 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes these changes to
newAcctUpdates:dbPathPrefix. Since the method is test-only and all usages rely on".", I'm guessing customization is not needed. If the preference is to use the parameter, let me know.l.trackers.initialize. It seemed prudent to check the returned error.I considered these changes while reviewing #4275. Consider the PR optional. If folks don't think it's worth pulling in, I'll happily close it.
Test Plan
gotestsum -- ./ledger