testing: set pprof labels for goroutines that use the same code for different cases#4350
Merged
algorandskiy merged 7 commits intoalgorand:masterfrom Jun 27, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4350 +/- ##
=======================================
Coverage 55.87% 55.88%
=======================================
Files 482 482
Lines 68571 68578 +7
=======================================
+ Hits 38317 38325 +8
+ Misses 27652 27650 -2
- Partials 2602 2603 +1 ☔ View full report in Codecov by Sentry. |
winder
previously approved these changes
Sep 2, 2022
Contributor
winder
left a comment
There was a problem hiding this comment.
Neat. The docs on pprof.Do weren't really helpful for me, and I haven't spent a lot of time with profiling. It looks correct according to the blog post.
jannotti
reviewed
Sep 8, 2022
Contributor
jannotti
left a comment
There was a problem hiding this comment.
How did you decide what to label? git grep "go.*()" and dig around? Or stuff you knew was interesting?
655672a to
f458336
Compare
Contributor
|
@cce could you rebase it? |
algorandskiy
approved these changes
Jun 20, 2024
jasonpaulos
approved these changes
Jun 20, 2024
Contributor
|
I suggest not merging before p2p branch due to conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sets a few profiler labels to identify a selection of goroutines used by algod. Since profiler data already lets you filter by function, we only need labels for cases where the same function is used by multiple goroutines for different cases. (E.g. low-prority worker pool vs high-priority worker pool; dedicated deserialization goroutines for different message types)