Typo Fix: "Transcation" to "Transaction"#4248
Merged
Merged
Conversation
algoganesh
changed the title
winder
reviewed
Jul 14, 2022
| // VerifiedTranscationsCacheSize defines the number of transactions that the verified transactions cache would hold before cycling the cache storage in a round-robin fashion. | ||
| VerifiedTranscationsCacheSize int `version[14]:"30000"` | ||
| // VerifiedTransactionsCacheSize defines the number of transactions that the verified transactions cache would hold before cycling the cache storage in a round-robin fashion. | ||
| VerifiedTransactionsCacheSize int `version[14]:"30000"` |
Contributor
There was a problem hiding this comment.
Oops, I don't think we can change this one. Since it's in the config file it could break existing configs.
@algorandskiy do you know if there's a way to fix this typo?
Contributor
There was a problem hiding this comment.
We would have to introduce both names, and have one copy its value to the other at startup time, and error if they were both set
Contributor
There was a problem hiding this comment.
Could you revert this part of the change and we can fix just the other typos?
Codecov Report
@@ Coverage Diff @@
## master #4248 +/- ##
==========================================
- Coverage 55.35% 55.30% -0.06%
==========================================
Files 395 395
Lines 50143 50143
==========================================
- Hits 27759 27731 -28
- Misses 20011 20035 +24
- Partials 2373 2377 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. |
winder
approved these changes
Aug 29, 2022
algorandskiy
approved these changes
Sep 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed "Transcation" typo
Test Plan