Skip to content

testing: fix randomly failing TestPseudonodeFailedEnqueuedTasks #3683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tsachiherman merged 1 commit into from
Feb 25, 2022
Merged

testing: fix randomly failing TestPseudonodeFailedEnqueuedTasks #3683

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions agreement/pseudonode_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,11 +520,12 @@ func TestPseudonodeFailedEnqueuedTasks(t *testing.T) {
for i := 0; i < pseudonodeVerificationBacklog*2; i++ {
ch, err = pb.MakeProposals(context.Background(), startRound, period(i))
if err != nil {
require.Subset(t, []int{pseudonodeVerificationBacklog, pseudonodeVerificationBacklog + 1}, []int{i})
require.ErrorAs(t, errPseudonodeBacklogFull, &err)
break
}
channels = append(channels, ch)
}
enqueuedProposals := len(channels)
require.Error(t, err, "MakeProposals did not returned an error when being overflowed with requests")
require.True(t, errors.Is(err, errPseudonodeBacklogFull))

Expand All @@ -533,17 +534,17 @@ func TestPseudonodeFailedEnqueuedTasks(t *testing.T) {
for i := 0; i < pseudonodeVerificationBacklog*2; i++ {
ch, err = pb.MakeVotes(context.Background(), startRound, period(i), step(i%5), makeProposalValue(period(i), accounts[0].Address()), persist)
if err != nil {
require.Subset(t, []int{pseudonodeVerificationBacklog, pseudonodeVerificationBacklog + 1}, []int{i})
require.ErrorAs(t, errPseudonodeBacklogFull, &err)
break
}
channels = append(channels, ch)
}
require.Error(t, err, "MakeVotes did not returned an error when being overflowed with requests")

enqueuedVotes := len(channels) - enqueuedProposals
// drain output channels.
for _, ch := range channels {
drainChannel(ch)
}
require.Equal(t, 330, subStrLogger.instancesFound[0])
require.Equal(t, 330, subStrLogger.instancesFound[1])
require.Equal(t, enqueuedVotes*len(accounts), subStrLogger.instancesFound[0])
require.Equal(t, enqueuedProposals*len(accounts), subStrLogger.instancesFound[1])
}