DevOps: Regen net.json for scenario2 test to include api endpoints for nodes.

[egieseke]

Summary

Regen scenario 2 net.json file to include API endpoints for nodes.

Test Plan

Testing with scenario2 recipe with cicd perf pipeline.

[codecov-commenter]

Codecov Report

Merging #3654 (de2e615) into master (468d34b) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3654      +/-   ##
==========================================
- Coverage   48.12%   48.12%   -0.01%     
==========================================
  Files         381      381              
  Lines       62214    62214              
==========================================
- Hits        29939    29938       -1     
+ Misses      28847    28844       -3     
- Partials     3428     3432       +4     

Impacted Files	Coverage Δ
crypto/merkletrie/trie.go	66.42% <0.00%> (-2.19%)	⬇️
crypto/merkletrie/node.go	91.62% <0.00%> (-1.87%)	⬇️
ledger/acctupdates.go	65.27% <0.00%> (-1.14%)	⬇️
catchup/peerSelector.go	98.95% <0.00%> (-1.05%)	⬇️
network/wsPeer.go	68.61% <0.00%> (-0.28%)	⬇️
network/wsNetwork.go	62.99% <0.00%> (+0.19%)	⬆️
catchup/service.go	70.12% <0.00%> (+1.48%)	⬆️
ledger/blockqueue.go	85.05% <0.00%> (+2.87%)	⬆️
cmd/algoh/blockWatcher.go	80.95% <0.00%> (+3.17%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 468d34b...de2e615. Read the comment docs.

[ghost]

Looks good.

[algobarb]

Looks good, but does opening these API endpoints impact the amount of traffic going to telemetry? Just trying to still understand why Prometheus recently went down.

[algobarb]

Thanks for removing netaddress for scenario2. Should we also remove it everywhere else that we recently added it to, before we forget?

[algobarb]

Thanks for removing the NetAddress from custom and scenario2.

[egieseke]

Looks good, but does opening these API endpoints impact the amount of traffic going to telemetry? Just trying to still understand why Prometheus recently went down.

These endpoints allow the bandwidth tool to communicate with the nodes and collect the bandwidth data.

[algojack]

lgtm