Skip to content

testing: Fix a typo in agreement test#3651

Merged
tsachiherman merged 1 commit intoalgorand:masterfrom
algorandskiy:pavel/agreement-test-fix
Feb 18, 2022
Merged

testing: Fix a typo in agreement test#3651
tsachiherman merged 1 commit intoalgorand:masterfrom
algorandskiy:pavel/agreement-test-fix

Conversation

@algorandskiy
Copy link
Copy Markdown
Contributor

Summary

Fix for a strange assert found by JJ

Test Plan

This is a test fix

Copy link
Copy Markdown
Contributor

@jannotti jannotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems right to me.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 17, 2022

Codecov Report

Merging #3651 (2b69cee) into master (cbf1939) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3651      +/-   ##
==========================================
- Coverage   48.10%   48.05%   -0.05%     
==========================================
  Files         381      381              
  Lines       62080    62080              
==========================================
- Hits        29864    29833      -31     
- Misses      28800    28820      +20     
- Partials     3416     3427      +11     
Impacted Files Coverage Δ
util/metrics/gauge.go 68.00% <0.00%> (-2.67%) ⬇️
util/metrics/counter.go 78.57% <0.00%> (-2.39%) ⬇️
network/wsPeer.go 68.88% <0.00%> (-2.23%) ⬇️
catchup/peerSelector.go 98.95% <0.00%> (-1.05%) ⬇️
ledger/acctupdates.go 65.46% <0.00%> (-0.95%) ⬇️
data/transactions/verify/txn.go 44.15% <0.00%> (-0.87%) ⬇️
catchup/service.go 69.38% <0.00%> (-0.75%) ⬇️
network/wsNetwork.go 62.79% <0.00%> (-0.50%) ⬇️
ledger/internal/eval.go 71.87% <0.00%> (-0.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbf1939...2b69cee. Read the comment docs.

@tsachiherman tsachiherman changed the title Fix a typo in agreement test testing: Fix a typo in agreement test Feb 18, 2022
@tsachiherman tsachiherman merged commit a6f1b9e into algorand:master Feb 18, 2022
@algorandskiy algorandskiy deleted the pavel/agreement-test-fix branch March 16, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants