goal node create improvements#3639
Merged
tsachiherman merged 4 commits intoalgorand:masterfrom Feb 22, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3639 +/- ##
==========================================
+ Coverage 48.06% 49.82% +1.75%
==========================================
Files 381 382 +1
Lines 62080 64264 +2184
==========================================
+ Hits 29841 32019 +2178
- Misses 28818 28823 +5
- Partials 3421 3422 +1
Continue to review full report at Codecov.
|
jasonpaulos
previously approved these changes
Feb 16, 2022
Contributor
jasonpaulos
left a comment
There was a problem hiding this comment.
Changes make sense to me
Contributor
Author
|
@tsachiherman followed your suggestion and embedded genesis files. |
b48a24b to
7035846
Compare
winder
reviewed
Feb 17, 2022
winder
reviewed
Feb 17, 2022
jasonpaulos
reviewed
Feb 17, 2022
jasonpaulos
approved these changes
Feb 17, 2022
Contributor
Author
|
Closes #1686 |
This was referenced Feb 28, 2022
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--full-configoptions allows saving config file with all options, not only non-default.Test Plan
Tested manually