DevOps: Fix bandwidth testing

[egieseke]

Fixed problem running bandwidth performance testing with the custom and scenario2 recipes by enabling the API endpoints for nodes and nonparticipating nodes.

Summary

Allow bandwidth testing with custom and scenario 2 recipes.

Test Plan

Tested using the updated custom recipe. The performance pipeline was completed successfully and the datadog bandwidth chart was updated.

[codecov-commenter]

Codecov Report

Merging #3638 (2b052c0) into master (212edb3) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3638      +/-   ##
==========================================
- Coverage   48.06%   48.05%   -0.01%     
==========================================
  Files         381      381              
  Lines       62080    62080              
==========================================
- Hits        29836    29832       -4     
  Misses      28822    28822              
- Partials     3422     3426       +4     

Impacted Files	Coverage Δ
util/metrics/gauge.go	68.00% <0.00%> (-2.67%)	⬇️
util/metrics/counter.go	78.57% <0.00%> (-2.39%)	⬇️
catchup/peerSelector.go	98.95% <0.00%> (-1.05%)	⬇️
network/requestTracker.go	71.12% <0.00%> (+0.86%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 212edb3...2b052c0. Read the comment docs.

[egieseke]

Successfully tested with Custom recipe and bandwidth testing enabled. #3638

[tsachiherman]

I wouldn't go that far and call this is bug.. But this change makes perfect sense.
It would be nice if you were to go over all the other recipes and update them as well, but it's perfectly fine as is.

[algobarb]

Can we document somewhere that "NetAddress": "{{NetworkPort}}", "APIEndpoint": "{{APIEndpoint}}"
is a requirement to run bandwidth testing? Maybe Confluence?

[egieseke]

Can we document somewhere that "NetAddress": "{{NetworkPort}}", "APIEndpoint": "{{APIEndpoint}}" is a requirement to run bandwidth testing? Maybe Confluence?

@algobarb good thinking, I added an info note here: https://algorand.atlassian.net/wiki/spaces/DEVOPS/pages/442433537/Automated+Performance+Testing+Framework