testing: fix bug in TestParticipationAccountsExpirationFuture/TestParticipationAccountsExpirationNonFuture

[tsachiherman]

Summary

This test had a bug, where it was sending a transaction to one node2, waiting for the transaction to be included in a block on node1, and then pulling the account data from node2.

Since the test failed to wait for node2 to be at the same round as node1, there is no guarantee that the account data fetched from node2 is the same as the account data that was just updated in the block.

Separately from that, the fixture.WaitForTxnConfirmation call was not tested for its return value.

Test Plan

Use Circle-CI.

[codecov-commenter]

Codecov Report

Merging #3616 (377910d) into master (53b157b) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3616      +/-   ##
==========================================
+ Coverage   48.05%   48.09%   +0.04%     
==========================================
  Files         381      381              
  Lines       62074    62074              
==========================================
+ Hits        29829    29854      +25     
+ Misses      28822    28794      -28     
- Partials     3423     3426       +3     

Impacted Files	Coverage Δ
cmd/algoh/blockWatcher.go	77.77% <0.00%> (-3.18%)	⬇️
ledger/blockqueue.go	82.18% <0.00%> (-2.88%)	⬇️
network/wsPeer.go	68.05% <0.00%> (-1.12%)	⬇️
ledger/acctupdates.go	66.60% <0.00%> (+0.18%)	⬆️
network/wsNetwork.go	62.99% <0.00%> (+0.19%)	⬆️
network/requestTracker.go	71.12% <0.00%> (+0.86%)	⬆️
data/abi/abi_type.go	88.62% <0.00%> (+0.94%)	⬆️
cmd/tealdbg/debugger.go	73.86% <0.00%> (+1.00%)	⬆️
crypto/merkletrie/node.go	93.48% <0.00%> (+1.86%)	⬆️
node/node.go	25.27% <0.00%> (+1.86%)	⬆️
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53b157b...377910d. Read the comment docs.