catchpointdump: set genesis proto version#3596
Merged
tsachiherman merged 3 commits intoalgorand:masterfrom Feb 8, 2022
Merged
Conversation
algorandskiy
force-pushed
the
pavel/catchpointdump-block
branch
from
1bb13a5 to
cdffffe
Compare
algorandskiy
force-pushed
the
pavel/catchpointdump-block
branch
from
cdffffe to
a834f11
Compare
algorandskiy
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3596 +/- ##
==========================================
- Coverage 47.59% 47.58% -0.01%
==========================================
Files 370 370
Lines 60093 60093
==========================================
- Hits 28601 28595 -6
- Misses 28183 28185 +2
- Partials 3309 3313 +4
Continue to review full report at Codecov.
|
algorandskiy
force-pushed
the
pavel/catchpointdump-block
branch
from
cfc718e to
32c0f84
Compare
tsachiherman
approved these changes
Feb 8, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Catchpointdump does not have access to a ledger and it does not know
which consensus params is to use as genesis state on rewards calculation
that can lead to division by zero panic.
This PR sets a hardcoded value to
ConsensusCurrentVersion.Additionally, let
netsubcommand to return non-zero exit codeto indicate nothing was downloaded.
To do that I converted it to
cobra.RunE-style method in order to usea standard cobra's error reporting and exit code setter.
Test Plan
Tested manually