bug fix : tx sync was incorrectly validating transactions#3554
Merged
tsachiherman merged 4 commits intoalgorand:masterfrom Feb 2, 2022
Merged
bug fix : tx sync was incorrectly validating transactions#3554tsachiherman merged 4 commits intoalgorand:masterfrom
tsachiherman merged 4 commits intoalgorand:masterfrom
Conversation
algonautshant
previously approved these changes
Feb 2, 2022
Contributor
algonautshant
left a comment
There was a problem hiding this comment.
Looks great.
Just one issue.
algonautshant
approved these changes
Feb 2, 2022
Codecov Report
@@ Coverage Diff @@
## master #3554 +/- ##
==========================================
- Coverage 47.59% 47.57% -0.03%
==========================================
Files 370 370
Lines 60109 60114 +5
==========================================
- Hits 28609 28598 -11
- Misses 28189 28201 +12
- Partials 3311 3315 +4
Continue to review full report at Codecov.
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The TestSyncFromClient was randomly failing. This is a real issue in production code, and the fix it pretty trivial.
Test Plan
Use existing tests to verify test.