Skip to content

[Other] CircleCI pipeline change for binary uploads #3381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
algojohnlee merged 19 commits into from
Jan 12, 2022
Merged

[Other] CircleCI pipeline change for binary uploads #3381

Changes from 18 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
dab1b30
test NO_BUILD parameter
algobarb Jan 6, 2022
f055039
fix no_build variable reference
algobarb Jan 6, 2022
f48c2db
remove slack for testing and change attach workspace
algobarb Jan 6, 2022
4163255
remove NO_BUILD flag when set to false
algobarb Jan 6, 2022
4c3084b
test upload_nightly_binaries works as expected
algobarb Jan 6, 2022
06f8b15
test upload_nightly_binaries works as expected
algobarb Jan 6, 2022
2c7280b
fix branch name for testing
algobarb Jan 6, 2022
4a017bc
change where the no_build conditional lies
algobarb Jan 6, 2022
6dc9bd4
disable slack while testing
algobarb Jan 6, 2022
33e02c9
test no_build=false again
algobarb Jan 6, 2022
090aeb0
clean up debugging
algobarb Jan 6, 2022
6a26c9f
reduce the code in upload_binaries_command
algobarb Jan 6, 2022
4d16e8f
test no_build=true
algobarb Jan 6, 2022
648c43c
clean up config file
algobarb Jan 6, 2022
63096cb
test no_build=true
algobarb Jan 10, 2022
d11d0f7
test circleci/1809 branch no_build=true
algobarb Jan 10, 2022
5de287c
test NO_BUILD=false
algobarb Jan 10, 2022
cd69d93
remove debugging and testing code
algobarb Jan 10, 2022
acadf4b
readd newline
algobarb Jan 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,6 @@ workflows:
context:
- slack-secrets
- aws-secrets

#- windows_x64_build

commands:
Expand Down Expand Up @@ -478,11 +477,14 @@ commands:
- attach_workspace:
at: << parameters.build_dir >>
- run:
name: Upload binaries << parameters.platform >>
name: Upload Binaries << parameters.platform >>
command: |
if [ "${CIRCLE_BRANCH}" = "rel/nightly" ]
then
export NO_BUILD="true"
fi
export PATH=$(echo "$PATH" | sed -e "s|:${HOME}/\.go_workspace/bin||g" | sed -e 's|:/usr/local/go/bin||g')
export GOPATH="<< parameters.build_dir >>/go"
export NO_BUILD=true
export TRAVIS_BRANCH=${CIRCLE_BRANCH}
scripts/travis/deploy_packages.sh
- when:
Expand Down Expand Up @@ -705,4 +707,4 @@ jobs:
- upload_binaries_command:
platform: << parameters.platform >>
- slack/notify:
<<: *slack-fail-event
<<: *slack-fail-event
Comment thread
algobarb marked this conversation as resolved.
Outdated