Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions logging/log.go
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,13 @@ func (l logger) GetTelemetrySession() string {
return l.loggerState.telemetry.telemetryConfig.SessionGUID
}

func (l logger) GetTelemetryVersion() string {
if !l.GetTelemetryEnabled() {
return ""
}
return l.loggerState.telemetry.telemetryConfig.Version
}

func (l logger) GetTelemetryHostName() string {
if !l.GetTelemetryEnabled() {
return ""
Expand Down
5 changes: 4 additions & 1 deletion logging/telemetry.go
Original file line number Diff line number Diff line change
Expand Up @@ -132,12 +132,14 @@ func ReadTelemetryConfigOrDefault(dataDir string, genesisID string) (cfg Telemet
return
}
}
ch := config.GetCurrentVersion().Channel
ver := config.GetCurrentVersion()
ch := ver.Channel
// Should not happen, but default to "dev" if channel is unspecified.
if ch == "" {
ch = "dev"
}
cfg.ChainID = fmt.Sprintf("%s-%s", ch, genesisID)
cfg.Version = ver.String()
return cfg, err
}

Expand Down Expand Up @@ -264,6 +266,7 @@ func (t *telemetryState) logTelemetry(l logger, message string, details interfac
entry := l.entry.WithFields(Fields{
"session": l.GetTelemetrySession(),
"instanceName": l.GetInstanceName(),
"v": l.GetTelemetryVersion(),
Comment thread
cce marked this conversation as resolved.
})
// Populate entry like logrus.entry.log() does
entry.Time = time.Now()
Expand Down
1 change: 1 addition & 0 deletions logging/telemetryCommon.go
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ type TelemetryConfig struct {
FilePath string // Path to file on disk, if any
ChainID string `json:"-"`
SessionGUID string `json:"-"`
Version string `json:"-"`
UserName string
Password string
}
Expand Down
7 changes: 6 additions & 1 deletion logging/telemetryFilteredHook.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ func (hook *telemetryFilteredHook) Fire(entry *logrus.Entry) error {
if entry.Level <= hook.reportLogLevel {
// Logging entry at a level which should include log history
// Create a new entry augmented with the history field.
newEntry := entry.WithFields(Fields{"log": hook.history.string(), "session": hook.sessionGUID})
newEntry := entry.WithFields(Fields{"log": hook.history.string(), "session": hook.sessionGUID, "v": hook.telemetryConfig.Version})
newEntry.Time = entry.Time
newEntry.Level = entry.Level
newEntry.Message = entry.Message
Expand All @@ -82,6 +82,11 @@ func (hook *telemetryFilteredHook) Fire(entry *logrus.Entry) error {
} else {
newEntry = entry.WithField("session", hook.sessionGUID)
}

// Also add version field, if not already present.
if _, has := entry.Data["v"]; !has {
newEntry = newEntry.WithField("v", hook.telemetryConfig.Version)
}
return hook.wrappedHook.Fire(newEntry)
}

Expand Down