Fix dryrun crash on rewards calculation#2894
Merged
Merged
Conversation
jasonpaulos
approved these changes
Sep 15, 2021
Contributor
jasonpaulos
left a comment
jasonpaulos
left a comment
There was a problem hiding this comment.
Looks like a good fix to me
Codecov Report
@@ Coverage Diff @@
## master #2894 +/- ##
==========================================
- Coverage 47.27% 47.27% -0.01%
==========================================
Files 355 355
Lines 57199 57202 +3
==========================================
+ Hits 27040 27041 +1
- Misses 27101 27102 +1
- Partials 3058 3059 +1
Continue to review full report at Codecov.
|
algobarb
pushed a commit
that referenced
this pull request
Sep 17, 2021
Merged
tsachiherman
pushed a commit
that referenced
this pull request
Sep 17, 2021
 # Highlights This version adds debugging for itxn programs and includes a bugfix for dryrun crashes. **This release does not contain a protocol upgrade.** # Changes 1. TEAL * Added * Enable debugging itxn programs (#2900) * Fixed * Fix dryrun crash on rewards calculation (#2894) ## Additional Resources * [Algorand Forum](https://forum.algorand.org) * [Developer Documentation](https://developer.algorand.org)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dryrun/tealdbg ledgers do not have block info so cannot provide correct value of
rewardLevelused in balance calculation forbalanceopcode. Fixed by clearingRewardBasefield in account data returned by dryrun/tealdbg ledgers.The crash was reported at the community forum.
Test Plan
Test added