fix issue with checking RUN_EXPECT when listing packages#2863
Merged
Conversation
algorandskiy
approved these changes
Sep 9, 2021
algorandskiy
approved these changes
Sep 9, 2021
Codecov Report
@@ Coverage Diff @@
## master #2863 +/- ##
==========================================
+ Coverage 47.34% 47.35% +0.01%
==========================================
Files 351 351
Lines 56523 56523
==========================================
+ Hits 26758 26765 +7
+ Misses 26758 26752 -6
+ Partials 3007 3006 -1
Continue to review full report at Codecov.
|
algojack
approved these changes
Sep 9, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@algoidan noticed we were not running some non-expect e2e-go tests and we spotted this issue in the test script when checking the value of RUN_EXPECT.
Test Plan
Check to ensure non-expect e2e-go tests are run as expected.