Increase coverage in AVM code. Bug fix in account fields of tx_field#2840
Merged
Conversation
Intended to just increase coverage in AVM, but doing so found a bug. (Go figure.) tx_field should only allow actual addresses for address fields, rather than low integers as references from the Account array.
Codecov Report
@@ Coverage Diff @@
## master #2840 +/- ##
=======================================
Coverage 47.28% 47.29%
=======================================
Files 351 351
Lines 56381 56387 +6
=======================================
+ Hits 26659 26666 +7
- Misses 26730 26731 +1
+ Partials 2992 2990 -2
Continue to review full report at Codecov.
|
jasonpaulos
approved these changes
Sep 7, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intended to just increase coverage in AVM, but doing so found a
bug. (Go figure.) tx_field should only allow actual addresses for
address fields, rather than low integers as references from the
Account array.
Test Plan
Lots more tests that increase coverage, especially for tx_field.