Display app address in goal app info & show logs are binary in REST API#2836
Merged
Conversation
goal app info & show logs are binary in REST APIgoal app info & show logs are binary in REST API
jannotti
previously approved these changes
Sep 3, 2021
Contributor
jannotti
left a comment
There was a problem hiding this comment.
I dig the auto base64.
Linter is mad about partitiontest.
Codecov Report
@@ Coverage Diff @@
## master #2836 +/- ##
==========================================
- Coverage 47.28% 47.26% -0.02%
==========================================
Files 351 351
Lines 56381 56382 +1
==========================================
- Hits 26659 26651 -8
- Misses 26730 26737 +7
- Partials 2992 2994 +2
Continue to review full report at Codecov.
|
jannotti
approved these changes
Sep 7, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a follow up to #2661. It adds the app account address to the
goal app infocommand, and it changes the log item type format in the REST API to "byte" in order to show that it's binary data. As a bonus, the encoder will automatically convert to base64 for us.Test Plan
Added a unit test to verify the encoder converts logs to base64.