Skip to content

check fewer rounds in ledger.TestArchival to speed it up#28

Merged
zeldovich merged 1 commit intoalgorand:masterfrom
zeldovich:testarchival
Jun 18, 2019
Merged

check fewer rounds in ledger.TestArchival to speed it up#28
zeldovich merged 1 commit intoalgorand:masterfrom
zeldovich:testarchival

Conversation

@zeldovich
Copy link
Copy Markdown
Contributor

No description provided.

@zeldovich zeldovich requested a review from derbear June 14, 2019 15:35
Copy link
Copy Markdown
Contributor

@derbear derbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this test more deterministic by using our seeded PRNG for the random check?

@Karmastic
Copy link
Copy Markdown
Contributor

Can we make this test more deterministic by using our seeded PRNG for the random check?

Nickolai - any plans to do what Derek suggested? If not, let's get this approved and checked in.

@zeldovich
Copy link
Copy Markdown
Contributor Author

We talked with Derek offline and decided to skip that. Will merge once there's an approval.

@zeldovich zeldovich merged commit 0d9b7c1 into algorand:master Jun 18, 2019
@zeldovich zeldovich deleted the testarchival branch June 18, 2019 13:01
derbear pushed a commit to derbear/go-algorand that referenced this pull request Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants