Disable expect tests again#2790
Merged
Merged
Conversation
* After re-enabling we started seeing failures on other e2e-go tests due to unsufficient resources to allow algod making new rounds * Possible solution is to run expect tests as a separate stage on CI go test ./test/e2e-go/cli/goal/expect/... -run TestGoalWithExpect
algobarb
approved these changes
Aug 23, 2021
tsachiherman
approved these changes
Aug 23, 2021
Codecov Report
@@ Coverage Diff @@
## master #2790 +/- ##
=======================================
Coverage 47.10% 47.10%
=======================================
Files 349 349
Lines 56354 56354
=======================================
+ Hits 26545 26547 +2
+ Misses 26836 26833 -3
- Partials 2973 2974 +1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
due to unsufficient resources to allow algod making new rounds
go test ./test/e2e-go/cli/goal/expect/... -run TestGoalWithExpect