[GOAL2-743] Check and return error in AlgorandFullNode::BroadcastSignedTxn#26
Merged
derbear merged 2 commits intoalgorand:masterfrom Jun 14, 2019
Merged
Conversation
|
|
EvanJRichard
changed the title
derbear
changed the title
derbear
pushed a commit
to derbear/go-algorand
that referenced
this pull request
Mar 26, 2020
Add JSON input file format for application calls.
jasonpaulos
pushed a commit
to jasonpaulos/go-algorand
that referenced
this pull request
Nov 3, 2022
* Delete extraneous function makeTestBlock inline * Add test for blockstats event details * Delete another comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AlgorandFullNode::BroadcastSignedTxnchecks, logs, and returns an error if an error occurs at any step, except for the final step where the transaction is sent to the networking stack for broadcast. This PR proposes to check, log, and return that error if it occurs as well.Testing
Test suite passes on my machine and automated test suite must pass before merge.